search

doctrine / DoctrinePHPCRBundle

This bundle integrates Doctrine PHPCR ODM and PHPCR backends into Symfony
http://phpcr.github.com
MIT License
156 stars 66 forks source link

revert BC break with command return types #382

Closed dbu closed 1 year ago

alexander-schranz commented 10 months ago

@dbu I just stumble again over the problem in https://github.com/doctrine/DoctrinePHPCRBundle/pull/369

doctrine/phpcr-bundle (2.4.3) and jackalope/jackalope-jackrabbit (1.4.5). If we remove the return types here we need also remove them again from jackalope/jackalope-jackrabbit 1.x

Bildschirmfoto 2023-11-13 um 16 59 39

dbu commented 10 months ago

dang, this thing still hunting us. https://github.com/jackalope/jackalope-jackrabbit/pull/179

i should really tag the new major versions for modern symfony.

dbu commented 10 months ago

i tagged 1.4.6 - does that fix it?

alexander-schranz commented 10 months ago

@dbu did fix it, thank you!