Closed EmanueleMinotto closed 9 years ago
Why do you break BC on the Annotations namespaces so drastically? This requires changes to every user for no good reason.
Its not documented in the PR description that you changed the Annotation namespaces as well
just tried to align it with the same doctrine2 (before a v1 release), anyway no problem, I'm going to move annotations back to Doctrine\KeyValueStore\Mapping\Annotations
:+1:
@beberlei done, let me know if I should squash the commits
@EmanueleMinotto please move the driver back as well into the Doctrine\KeyValueStore\Mapping
namespace.
It is not really important to be consistent with ORM here, and it doesn't make a huge difference.
In general, when you do want to break BC, then you should document this in a CHANGELOG.md
file, like Symfony does or UPGRADE.md
like Doctrine ORM does.
Should be a solution (a first draft at least) for #12 and #13
The identifier can also be a string. A single attribute as identifier should be a common thing (I think).