search

doctrine / KeyValueStore

Abstraction for Key-Value to Plain Old PHP Object mapping
http://www.doctrine-project.org
MIT License
200 stars 59 forks source link

Added deprecation annotation #56

Closed EmanueleMinotto closed 8 years ago

EmanueleMinotto commented 8 years ago

These classes are currently used only for the deprecated WindowsAzureTableStorage, so imo should be marked as deprecated too.

SenseException commented 8 years ago

Seems fine and there is already an alternative for WindowsAzureTableStorage a user can switch to. Will WindowsAzureTableStorage and its dependent classes removed in a future version of KeyValueStore? Should the KeyValueStore version in that the classes and the interface are removed named inside the deprecation message?

EmanueleMinotto commented 8 years ago

In the first release it will be still included and removed from v2 (https://github.com/doctrine/KeyValueStore/issues/46). The AzureSdkTableStorage should be used instead of the WindowsAzureTableStorage, do you suggest to write it in these annotations too?

SenseException commented 8 years ago

I suggest to name the version inside the deprecation messages when they will be removed. In that case v2.

Ocramius commented 8 years ago

:+1: