Fixed wrong instance reference

doctrine / KeyValueStore

Abstraction for Key-Value to Plain Old PHP Object mapping

http://www.doctrine-project.org

MIT License

200 stars 59 forks source link

Closed EmanueleMinotto closed 8 years ago

Ocramius commented 8 years ago

@EmanueleMinotto test required.

EmanueleMinotto commented 8 years ago

@Ocramius I'm trying to move from current tests (a mix of functional & unit tests, covering a small percentage of the source) to a full coverage with unit tests in the tests/refactoring branch (this change is covered here: https://github.com/doctrine/KeyValueStore/commit/f98158d5939f657db1d31adaf9282fb2f0279e13#diff-53f3cbd0c04bbc695439d89d9e894943R252).

Is it ok or not? Should I also add tests here anyway?

Ocramius commented 8 years ago

@EmanueleMinotto this particular case can most probably be unit tested

EmanueleMinotto commented 8 years ago

Imported a test from the new suite, covers this change too.

Ocramius commented 8 years ago

:+1: