search

doctrine / common

Doctrine Common
https://www.doctrine-project.org/projects/common.html
MIT License
5.79k stars 294 forks source link

Add generics to ClassUtils::getClass #931

Closed franmomu closed 3 years ago

franmomu commented 3 years ago

Ref: https://github.com/doctrine/common/pull/926

There has been a release of doctrine/persistence: 2.2, in that version Proxy interface is generic.

greg0ire commented 3 years ago

Let's wait for https://www.githubstatus.com/incidents/zbpwygxwb3gw to be resolved…

franmomu commented 3 years ago

@greg0ire I think a merge up is needed to fix the CS (with https://github.com/doctrine/common/commit/4773bc2b72ecec647f0729f8309b1e54c0797317)

greg0ire commented 3 years ago

Thanks @franmomu ! Don't hesitate to ping me if you have more open PRs laying around :sweat_smile:

franmomu commented 3 years ago

Thanks @franmomu ! Don't hesitate to ping me if you have more open PRs laying around 😅

Sure, thanks! To be honest I totally forgot about this one 😬