Support void return type for __clone magic method

doctrine / common

Doctrine Common

https://www.doctrine-project.org/projects/common.html

MIT License

5.79k stars 294 forks source link

Support void return type for __clone magic method #970

Closed deguif closed 2 years ago

deguif commented 2 years ago

Starting PHP 8.0, void an be type-hinted as return for __clone method. But proxy generated doesn't add this return type, which breaks the inherited contract.

malarzm commented 2 years ago

Thanks @deguif!

deguif commented 2 years ago

@greg0ire @malarzm thanks for the quick review, merge and release.