search

doctrine / couchdb-client

CouchDB Client library
MIT License
122 stars 68 forks source link

StreamClient does not support https #71

Open paulmer opened 7 years ago

paulmer commented 7 years ago

lib/Doctrine/CouchDB/HTTP/StreamClient has a hard coded protocol of http with a "TODO" comment to support SSL. I suggest at a minimum the attached patch to set the protocol based on the ssl option flag. Since the library supports the inherently insecure basic http authentication protocol, SSL support is very important.

paulmer commented 7 years ago

patch.txt

damiankloip commented 7 years ago

See https://github.com/doctrine/couchdb-client/pull/70

damiankloip commented 7 years ago

@paulmer you can also use our fork, which has that fix in already, https://github.com/relaxedws/couchdb-client