is final needed? - Githubissues

doctrine / couchdb-odm

A Document Mapper based on CouchDB

http://www.doctrine-project.org

MIT License

150 stars 53 forks source link

is final needed? #141

Closed juliangut closed 7 years ago

juliangut commented 7 years ago

https://github.com/doctrine/couchdb-odm/blob/master/lib/Doctrine/ODM/CouchDB/DocumentRepository.php#L102

Ocramius commented 7 years ago

The entire class should probably be final, but only the refresh method got added as final due to its out-of-interface signature, and the late addition. Due to BC compliance, it is no longer possible to make the class itself final.

If you aren't aware of the reasons, see:

http://ocramius.github.io/blog/when-to-declare-classes-final/#comment-3400988766
https://slamdunk.github.io/blog/when-to-declare-methods-final/