doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

allow the use of multiple transactions - one per file #209

Closed gnat42 closed 2 years ago

gnat42 commented 8 years ago

This allows the user to select whether they want a single transaction for all fixture files or one transaction per fixture file. This fixes a bug where I had a custom id generator that queries another table and increments an id there within its own transaction. It causes a segfault.

Fixes #126, #42 This is the rebased version of PR #132

That first PR was done prior to me really getting github PR workflow, and the attempted rebase failed. So here's the patch against latest master.

skillberto commented 8 years ago

Guys, whats going on with this? I need this modification but it's still under merging since 1 year, and an Issue since 2 years... What's the wrong?

ctaverne commented 7 years ago

Hi,

Why not merged for so long ? It could be interesting for us to reduce memory usage on big imports.

stof commented 7 years ago

@ctaverne because this is a BC break

ctaverne commented 7 years ago

Ok, so maybe you should remove this unavailable option: --multiple-transactions Use one transaction per fixture file instead of a single transaction for all

in the doctrine:fixtures:load command help

BafS commented 2 years ago

Any new about this PR? It would be great to have it merged, if possible.

BafS commented 2 years ago

Do we plan to merge it soon? If it's BC, what is the timeline for the next major? The PR is there since 7 years

Could we add the "v2.0.0" milestone tag?

greg0ire commented 2 years ago

@BafS we don't plan to merge it since many things are wrong:

Regarding the breaking change, I believe it could be worked around by getting the argument with func_get_args().

The PR is there since 7 years

So what? It has issues. Fix them if you want to see this merged.

derrabus commented 2 years ago

Closing in favor of #388.