Fix sorter issue - Githubissues

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.78k stars 224 forks source link

Fix sorter issue #240

Closed asaintvanne closed 8 years ago

asaintvanne commented 8 years ago

Fix #236 issue :

1/ On lib/Doctrine/Common/DataFixtures/Purger/ORMPurger.php

Node is not erased even if treated in dependencies
Reverse sort result as previous version

2/ On lib/Doctrine/Common/DataFixtures/Sorter/TopologicalSorter.php

Exception throwed according to new allowCyclicDependencies attribute

3/ On tests/Doctrine/Tests/Common/DataFixtures/Sorter/TopologicalSorterTest.php

A new test is written for cyclic dependencies

mikeSimonson commented 8 years ago

@stof @Ocramius From the PR #239 #234 #231, this one looks like the sanest approach. What's your thought on merging this one ?

peterrehm commented 8 years ago

@elpiafo Have you tested it with the tests provided by @mgonyan in #231?

asaintvanne commented 8 years ago

@peterrehm I meet an issue with @mgonyan tests on #231. ParentInterest and Interest are not well sorted. My branch is still compatible with 1.1.1 (cycling dependency exception is NOT thrown on bidirectional relation).

mikeSimonson commented 8 years ago

@elpiafo Thanks