doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.78k stars 224 forks source link

Fix ID of custom dbal types #267

Closed JustBlackBird closed 4 years ago

JustBlackBird commented 7 years ago

This PR is a fix for #254

Not sure if I didn't break anything but the tests are passing :smile:

JustBlackBird commented 7 years ago

Rebased

JustBlackBird commented 7 years ago

@Majkl578 I've moved type initialization to setUpBeforeClass. CI check is failed because it's unable to setup mongodb for php7.2 not because of the PR.

JustBlackBird commented 7 years ago

Is there anything else I should fix to get the PR merged?

kisprof commented 6 years ago

Hi there!

Whats the status of this PR? I just run into the same issue as in #254 and i was glad to see there is already a PR for it. Can i help in any way to speed up the merging process?

JustBlackBird commented 6 years ago

@Majkl578 ping

JustBlackBird commented 5 years ago

@Ocramius @Majkl578 Is there anything I should fix to get the PR finally merged?

JustBlackBird commented 4 years ago

I've rebased changes to fix merge conflict.

JustBlackBird commented 4 years ago

Seems that Doctrine\Tests\Common\DataFixtures\ORMPurgerTest::testGetAssociationTables test case is already broken in master :(

alcaeus commented 4 years ago

I’ll take a look after the holidays. Thanks for following up.

greg0ire commented 4 years ago

I addressed the issue in #333

JustBlackBird commented 4 years ago

@greg0ire thank you!

@alcaeus it seems that #333 should be merged before this one

greg0ire commented 4 years ago

It just got merged :)

greg0ire commented 4 years ago

333 is not merged up in master yet, hence why the build is not fixed. Are you sure you should target master though? Is there a BC-break in your PR?

EDIT: I don't think so, let me retarget this PR for you .

greg0ire commented 4 years ago

The unit tests pass, but the coding standard do not.

JustBlackBird commented 4 years ago

@greg0ire Thank you for your help with codding style

greg0ire commented 4 years ago

I amended your commit with a message that sums up what I believe is a correct explanation for your PR. Please tell me if I got it wrong.

JustBlackBird commented 4 years ago

I amended your commit with a message that sums up what I believe is a correct explanation for your PR. Please tell me if I got it wrong.

@greg0ire The message is fine, thank you!

greg0ire commented 4 years ago

Great, thanks @JustBlackBird !

JustBlackBird commented 4 years ago

@greg0ire thank you for getting the PR finally merged! :tada: