clean up phpcr executor

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.78k stars 224 forks source link

clean up phpcr executor #284

Closed dbu closed 6 years ago

dbu commented 6 years ago

use the DocumentManagerInterface
use php 7 static typing
remove unnecessary phpdoc blocks

dbu commented 6 years ago

is it intended use of this repository to extend the executor? there is only a BC break if somebody overwrites that method. guess we should have made those classes final to be sure.

unfortunately, i deleted my fork some time ago. do you have any idea how i can edit this now? can i somehow download a diff to recreate what is in here?

alcaeus commented 6 years ago

You can add fetch = +refs/pull/*/head:refs/remotes/origin/pr/* to the remote in .git/config, then checkout a new branch based on this PR.

alcaeus commented 6 years ago

To follow up on the other part of your question, yes, we should have made a lot of classes final, but that's how it is. For now, they are part of the public API, so we can neither make them final nor can we change any method signatures (except for some changes in the constructor signature since they don't cause signature mismatches).

dbu commented 6 years ago

thanks a lot for the git instructions, was not aware thats possible, pretty cool! continuing in #289