search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

Remove dependency on doctrine/common #300

Open deresh opened 5 years ago

deresh commented 5 years ago

Newer versions od doctrine deprecated doctrine/common package.

Please remove this dependency and depend on new doctrine packages as needed.

shehi commented 4 years ago

That'd be breaking for a lot of bundles that use the current version of this package, bundles that rely on doctrine-common. E.g. Faker uses doctrine-common to abstract the usages of ORM and ODM loaders.

alcaeus commented 4 years ago

@shehi that's wrong: all non-deprecated functionality has been extracted into other packages. If any library relies on transitive dependencies (e.g. import doctrine/data-fixtures and expect it to import doctrine/common), this is bad design on their part.

We will be phasing out the dependency to doctrine/common in the near future.

shehi commented 4 years ago

What I meant in general is code like this: https://github.com/fzaninotto/Faker/blob/master/src/Faker/ORM/Doctrine/EntityPopulator.php#L5 which use doctrine/common as abstraction interface in their persistence implementations. This type of lines are everywhere.

You will be transitioning them out in doctrine/data-fixtures 1.x or next major release? I am asking just to be 100% sure what you mean.

alcaeus commented 4 years ago

This interface has been moved to doctrine/persistence a while back, with doctrine/common requiring doctrine/persistence. This issue is about removing doctrine/common and replacing it with the individual packages. This will be done in a 1.x release as it doesn't constitute a breaking change as long as we don't change our public API.