Closed ruudk closed 4 years ago
How does PhpStorm handle the class-string type? I’m worried that it may not understand what’s going on...
I checked. It just sees it as array of mixed, and that was already the case :)
I'm sure PHPStorm will soon support all the new PHPStan/Psalm notations.
Great. I’ll take care of this after the holidays, as I need to check the branches and do some more work here for the persistence deprecations.
I believe this should be fixed in a patch release, would you agree?
Thanks! I agree.
@ruudk this means you shouldn't target master
@greg0ire Sorry, didn't get the hint. Changed the base branch now.
Triggering a new build, since #333 fixed it
@greg0ire Can we merge it? :)
I'm not sure: 1.3 is still maintained, isn't it affected by this too?
@greg0ire Changed base branch and rebased it :shipit:
Aaaaand the test fail… please cherry-pick b7532e4, that should fix it.
Sorry, but that's not part of this PR. Clearly 1.3.x- branch is broken. I tried to cherry pick it but that forces me to fix a merge conflict. This such a small change, that I already spend too much time on.
Ok don't worry, I'm going to take care of fixing the branch, just leave this open.
Ok so apparently it is no longer maintained (see https://github.com/doctrine/data-fixtures/pull/335), so targeting 1.4.x was the right thing to do, sorry.
Thanks @ruudk !
Hi, this made my phpstan in version 0.11.6
fail on
invalid type Doctrine\Common\DataFixtures\class
:disappointed:
Luckily, upgrading to ^0.12
version helped.
This makes it easier for PHPStan to understand what's going on.