search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

Fix DependentFixtureInterface return documentation #342

Closed orolyn closed 4 years ago

orolyn commented 4 years ago

This issue is causing problems for static analysis on projects using this library. Perhaps it was merely forgotten when introducing pslam?

greg0ire commented 4 years ago

Are you using an up-to-date version of psalm? @ruudk please advise.

orolyn commented 4 years ago

We're not using psalm. However we are using phpstan, the return type of class-string[] makes phpstan expect a return type of class, failing static analysis.

alcaeus commented 4 years ago

Closing: See #337 and #339. Upgrade to recent versions of phpstan (^0.12 IIRC) and it will work.

greg0ire commented 4 years ago

Are you using an up-to-date version of phpstan?

orolyn commented 4 years ago

0.11, updating it now, thanks.