search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

Allow Custom ORMPurger #347

Closed kissifrot closed 4 years ago

kissifrot commented 4 years ago

https://github.com/doctrine/DoctrineFixturesBundle/pull/307 on Bundle-side allowed to create custom Purger, however an instance of ORMPurger is needed. This PR allows a new ORMPurgerInterface to be used instead.

kissifrot commented 4 years ago

@alcaeus However CI complains about Interface suffix, however all other interfaces are sufixed, what should I do?

alcaeus commented 4 years ago

Since we can't rename the ORMPurger class, it's fine to add another exception for the new ORMPurgerInterface in phpcs.xml.dist: https://github.com/doctrine/data-fixtures/blob/265b209150ce6bfa22c3825bfcd512f5b5c32d3b/phpcs.xml.dist#L42

kissifrot commented 4 years ago

Since we can't rename the ORMPurger class, it's fine to add another exception for the new ORMPurgerInterface in phpcs.xml.dist:

https://github.com/doctrine/data-fixtures/blob/265b209150ce6bfa22c3825bfcd512f5b5c32d3b/phpcs.xml.dist#L42

Done :)

alcaeus commented 4 years ago

Thanks @kissifrot!