doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.77k stars 224 forks source link

Allows both doctrine/common 3.x & doctrine/persistence 2.x #349

Closed fruitwasp closed 4 years ago

fruitwasp commented 4 years ago

Q	A
Type	improvement
BC Break	yes
Fixed issues

Summary

Allows doctrine/common 3.x & doctrine/persistence 2.x
Bumps 2.x of doctrine/common to 2.13 because of release notes

Thoughts?

greg0ire commented 4 years ago

Thoughts?

I think I already expressed them in another of your PRs, but IMO you should start contributing a maximum of things to the stable branch first. This applies to allowing common 3 and persistence 2 I think.

fruitwasp commented 4 years ago

what about allowing doctrine/mongodb-odm 2.1.x? Required to allow doctrine/persistence 2.x (see https://github.com/doctrine/mongodb-odm/pull/2204

Ok to drop doctrine/mongodb-odm 1.x too?

greg0ire commented 4 years ago

what about allowing doctrine/mongodb-odm 2.1.x?

If both versions can be handled by a single version of data-fixtures, why not?

Ok to drop doctrine/mongodb-odm 1.x too?

Preferrably in a subsequent PR.

garak commented 4 years ago

Related PR in mongodb-odm has been merged

fruitwasp commented 4 years ago

tests seem to fail on registering annotations. The previously used AnnotationDriver::registerAnnotationClasses does no longer exist? Anyone got an idea on how to proceed?

greg0ire commented 4 years ago

The error message says it Call to undefined method MongoDB\Collection::getIndexInfo(), how do does this relate with registering annotations?

fruitwasp commented 4 years ago

Targets the 1.4.x stable branch now. Will bump doctrine/mongodb-odm in another pull request

weaverryan commented 4 years ago

Hi!

Giving this a gentle bump :). This library (and DoctrineFixturesBundle) is no longer installable out-of-the-box on Symfony 5 apps (ref):

composer create-project symfony/skeleton testing_data_fixtures
cd testing_data_fixtures
# will lock doctrine/common on v3
composer require doctrine/doctrine-bundle doctrine/orm

# this will fail because we're locked at doctrine/common v3
composer require doctrine/data-fixtures

It looks like there is a MongoDB issue that we're still checking into? Is that all?

Thanks!

greg0ire commented 4 years ago

It looks like there is a MongoDB issue that we're still checking into? Is that all?

I think this package needs to be made compatible with doctrine/mongodb-odm 2, yeah. When that's done, then the contents of this PR should be enough to fix the issue.

alcaeus commented 4 years ago

@greg0ire see https://github.com/doctrine/data-fixtures/pull/351.

greg0ire commented 4 years ago

351 has been merged, let's trigger a new build

fruitwasp commented 4 years ago

Looks like doctrine/common 3 & /persistence have been installed in the builds. Great work!

greg0ire commented 4 years ago

Thanks @fruitwasp !