search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

Migrate from Travis CI to GitHub Actions #353

Closed nicwortel closed 3 years ago

nicwortel commented 3 years ago

Travis CI builds are no longer working, so in order to have CI builds again this repository has to be migrated to GitHub Actions.

Also see https://github.com/orgs/doctrine/projects/7#card-50248167, https://github.com/doctrine/event-manager/pull/34.

nicwortel commented 3 years ago

Removing draft status to see if that triggers the build.

greg0ire commented 3 years ago

I think at least one Github Action must exist before they can appear, let me set one up real quick.

nicwortel commented 3 years ago

Ah, I didn't know that! Thanks 🙂

nicwortel commented 3 years ago

I decided to introduce PHPStan in a separate PR, as this project hasn't been analysed with PHPStan yet and results in errors even on level 0. Some of these errors appear to be solvable by installing doctrine/phpcr-odm as a dev-dependency, but I think the amount of changes required is high enough to justify a separate PR.

greg0ire commented 3 years ago

The goal of this PR should be to reproduce what's currently done on Travis so that entirely fine 👍

greg0ire commented 3 years ago

The PHPUnit constraint should be updated to ^8.0 so that we can use PCOV

nicwortel commented 3 years ago

~@greg0ire the build fails after applying your suggestion, I believe PCOV is only supported by PHPUnit 8 and higher.~

The PHPUnit constraint should be updated to ^8.0 so that we can use PCOV

Ah, I thought that was not possible because of PHP 7.1 support, but now I realise that this project already has PHP 7.2 as a minimum requirement. PHPUnit 8 supports PHP 7.2, so that should be possible. However, I'll have to upgrade PHPUnit and add return types to some methods.

greg0ire commented 3 years ago

I'll have to upgrade PHPUnit and add return types to some methods.

That was not a lot of methods, luckily :)

greg0ire commented 3 years ago

I think we're good code-wise. Some commits look like they can be fixed up into previous ones (for instance the XDebug to PCOV one), can you please take a look?

nicwortel commented 3 years ago

I think we're good code-wise. Some commits look like they can be fixed up into previous ones (for instance the XDebug to PCOV one), can you please take a look?

I've rebased the branch and merged some commits together.

greg0ire commented 3 years ago

Thanks again @nicwortel ! Great job!