search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.77k stars 224 forks source link

Upgrade the Doctrine Coding Standard #355

Closed nicwortel closed 3 years ago

nicwortel commented 3 years ago

See https://github.com/doctrine/event-manager/pull/33, https://github.com/orgs/doctrine/projects/7#card-50248429.

In order to support PHP 8, the Coding Standard repository needs to be updated.

greg0ire commented 3 years ago

You can add <config name="php_version" value="70200"/> towards the top, it might be helpful in avoiding some unwanted fixes.

nicwortel commented 3 years ago

Currently blocked because doctrine/mongodb-odm doesn't allow PHP 8 yet, see https://github.com/doctrine/mongodb-odm/pull/2248.

greg0ire commented 3 years ago

Currently blocked because doctrine/mongodb-odm doesn't allow PHP 8 yet, see doctrine/mongodb-odm#2248.

Then let's focus on upgrading phpcs and only that, shall we?

nicwortel commented 3 years ago

Then let's focus on upgrading phpcs and only that, shall we?

I have changed the PR title and removed the last commit. The build is running again, but should turn green in a minute.