Avoid inline literals in titles

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.76k stars 224 forks source link

Avoid inline literals in titles #384

Closed greg0ire closed 2 years ago

greg0ire commented 2 years ago

They result in weird links weird inline literals are replaced with hashes. Let us also add missing words in sentences above, this should make it easier to figure out that these are the same 2 options as below, or just make sentences correct.

Screenshot 2022-03-26 at 12-21-17 Doctrine Data Fixtures - Doctrine Data fixtures

I had to fiddle with CSS properties to make these links appear. Maybe this fix will result in the following weird behavior to disappear as well?

Peek 2022-03-26 11-51

greg0ire commented 2 years ago

Note that the first bug looks like it should be fixed by https://github.com/doctrine/rst-parser/pull/135 or https://github.com/doctrine/rst-parser/pull/124, but doctrine-website seems to be using a very outdated version of doctrine/rst-parser

SenseException commented 2 years ago

AFAIK the outdated version is used because of the buggy table rendering in the past that broke the builds. I started with an update for the website for using at least PHP 8, but some dependencies need to be updated too. I'm currently not able to work much in a week on different construction zones.