Add singleTransaction option for ORMExecutor

[BafS]

Reworked https://github.com/doctrine/data-fixtures/pull/209 to target 1.6.x and use func_get_args() to avoid BC use the constructor to avoid BC

[stof]

This PR needs tests covering the case of not using a single transaction

[BafS]

This PR needs tests covering the case of not using a single transaction

Thanks, I added some tests, let me know if it's enough.

[stof]

The test is exactly the same than the test not using multiple transactions. So to me, this means that the test has no value. If I revert all changes in the ORMExecutor::execute method, your test would still be passing.

[BafS]

I rebased my PR to use $this->em->wrapInTransaction() instead of $this->em->getConnection()->transactional() and added some tests to count the number of "transactional" calls

[greg0ire]

Please add documentation about the new feature.

[greg0ire]

@derrabus If you prefer to have MultipleTransactionORMExecutor extends AbstracExecutor, that's fine by me. I think there is a need for a design change here, but it might best be done outside this PR, and go further than what has been done here. Let us know what you think.

[BafS]

I updated the PR to make MultipleTransactionORMExecutor extends ORMExecutor, which is probably the easiest way to go but not the nicest (because inheritance). If you prefer I can extends the AbstracExecutor and share the logic with trait (which is not so nice either IMO). Not trivial to come up with a nice design without BC.

[derrabus]

Let me explore that path with the shared trait. I'll get back to you. And sorry for the back-and-forth on this PR. 😓

[BafS]

@derrabus Okay 👍 no problem, it's great to have feedback and to see things moving

[derrabus]

Here's my take: #396

[derrabus]

Closing in favor of #396.