Address commonexception deprecation

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions

http://www.doctrine-project.org

MIT License

2.76k stars 224 forks source link

Address commonexception deprecation #397

Closed MarcBrillault closed 2 years ago

greg0ire commented 2 years ago

@SenseException Marc is my colleague, and we wrote this PR together. In particular, this sentence: "We don't think anyone catches this exception in a catch (CommonException) statement". It's my personal opinion that a BC-break is OK in this case. If you feel otherwise, we can create 2.0.x and retarget to that.

SenseException commented 2 years ago

I see data-fixtures mostly in a dev env in projects, which is why I approved the PR. I wanted to be sure that nothing was missed with these changes and that the chosen version was on purpose.

greg0ire commented 2 years ago

Thanks @MarcBrillault !