doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.78k stars 224 forks source link

Avoid purging unrelated tables #404

Closed mpdude closed 2 years ago

mpdude commented 2 years ago

Assume the following class hierarchy:

/** @Entity */
class Parent {
    // @Id and other attributes here
}

/** @Entity */
class Child extends Parent {
    // @Id and other attributes here
}

Both entities have their own, completely unrelated database tables.

I think it is ok (at least, I have a project where it seems to work) to have two different Entity Managers configured, and the first one knows only about the Parent, the other about the Child entity.

When using the ORMPurger with the EntityManager for class Child, it should not try to truncate/delete the parent table. This is what this PR tries to do – do not include another table when we're not dependent on it, when there is no inheritance mapping relationship.

(OTOH, I'm a bit unsure if the approach is sane... Can the Child Entity Manager not know about Parent? If it needs to know that class, the way the ORMPurger works would be to include that table as well, since the ORMPurge purges all tables managed by a given EntityManager?)

stof commented 2 years ago

(OTOH, I'm a bit unsure if the approach is sane... Can the Child Entity Manager not know about Parent? If it needs to know that class, the way the ORMPurger works would be to include that table as well, since the ORMPurge purges all tables managed by a given EntityManager?)

If an entity extends another one, the EntityManager cannot known only the child class. That's not a supported usage of doctrine/orm (and would probably require weird hacks to even attempt doing that)

mpdude commented 2 years ago

Yeah, I became aware of that as I wrote the above description and wondered what I was doing…

mpdude commented 2 years ago

Given that the ORMPurger is designed to purge all entity classes in a given EntityManager, and that the EM cannot manage an entity class that inherits from another one without also knowing that parent class (as stof explained above), the current behavior makes sense.

Thank you for the clarification.