search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.78k stars 223 forks source link

Maintenance #436

Closed greg0ire closed 1 year ago

greg0ire commented 1 year ago

:thinking: I'm wondering if I need to install the mongodb extension to fix PHPStan, cc @alcaeus @franmomu

EDIT: doing so locally doesn't fix the issue.

franmomu commented 1 year ago

🤔 I'm wondering if I need to install the mongodb extension to fix PHPStan, cc @alcaeus @franmomu

EDIT: doing so locally doesn't fix the issue.

could be something related to the PHP version set in

https://github.com/doctrine/data-fixtures/blob/4892c74dd04a3ec7404b9586272d722325905c58/phpstan.neon.dist#L2

which is different from the PHP version running the job?

doctrine/mongodb-odm 2.5 only supports PHP >= 7.4

derrabus commented 1 year ago

Indeed. In other Doctrine projects, we've changed this setting to the highest supported PHP version. We should do the same here.

greg0ire commented 1 year ago

Ah well spotted @franmomu , that does fix the issue. I wouldn't have thought of checking this, thanks a lot!