doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.76k stars 224 forks source link

Add return types on public classes and interfaces #459

Closed GromNaN closed 4 months ago

GromNaN commented 6 months ago

Add return types to methods from the public API.

Follow-up https://github.com/doctrine/data-fixtures/pull/455#pullrequestreview-1782094062

GromNaN commented 6 months ago

I'll check why ObjectManager::getClassMetadata() return null for Doctrine\Tests\Common\DataFixtures\TestEntity\Role.

GromNaN commented 6 months ago

Psalm baseline updated. I was confused by the fact that both psalm and phpstan are used.

derrabus commented 4 months ago

Rebase needed.

derrabus commented 4 months ago

Can we enable this rule now?

https://github.com/doctrine/data-fixtures/blob/36d20789751e0fdef7540336d0fc0a69d6e07fa1/phpcs.xml.dist#L59-L62