search

doctrine / data-fixtures

Doctrine2 ORM Data Fixtures Extensions
http://www.doctrine-project.org
MIT License
2.78k stars 223 forks source link

Setup dependabot #475

Closed greg0ire closed 5 months ago

greg0ire commented 5 months ago

@derrabus, may I asked what your intent was with https://github.com/doctrine/data-fixtures/pull/453 ? I believe it's causing the build failure

derrabus commented 5 months ago

I wanted to test against upcoming releases (PHP 8.3, ORM 3, DBAL 4).

greg0ire commented 5 months ago

I believe this is caused by https://github.com/sebastianbergmann/phpunit/commit/63183f242af98a6fe17700a60062ebc49e0f5325

What should we do?

derrabus commented 5 months ago

Use the workaround?

Let's not use mocks here. My proposal: #476

Tweak config so that the "dev" build only allows dev versions of PHP, and doctrine/*?

In general: I think it's fine if the dev job fails from time to time because of changes upstream.

But we could of course also pin PHPUnit like we do on other repos. Maybe have dependabot bump our tools then?

greg0ire commented 5 months ago

But we could of course also pin PHPUnit like we do on other repos. Maybe have dependabot bump our tools then?

Sounds like a good idea 👍