search

doctrine / dbal

Doctrine Database Abstraction Layer
https://www.doctrine-project.org/projects/dbal.html
MIT License
9.44k stars 1.33k forks source link

SQL Anywhere driver PHP7 compatibility #2652

Closed deeky666 closed 4 years ago

deeky666 commented 7 years ago

Because of bumping the PHP requirements for DBAL 2.6 to PHP7+, our SQL Anywhere support is currently broken because SAP did not port their sqlanywhere to PHP7 (yet) and there currently is no statement about whether they are planning to do so. We need to figure out how to deal with this situation. Please blame SAP at: https://archive.sap.com/documents/docs/DOC-40537

deeky666 commented 7 years ago

/cc @efarrar

heiglandreas commented 7 years ago

The sourcecode is available @ http://d5d4ifzqzkhwt.cloudfront.net/drivers/php/sasql_php.zip …

deeky666 commented 7 years ago

@heiglandreas this is not compatible with PHP7 unfortunately. Is the driver still maintained by SAP? The latest version of the driver is compatible with PHP 5.6 which is already EOL!

heiglandreas commented 7 years ago

PHP 5.6 is not EOL! There's no active support anymore, but EOL for PHP 5.6 starts 1st January 2019! http://php.net/supported-versions.php

And I didn't mean that the source is OOTB compilable with PHP 7.x. But the basic info is available to adapt and then make it run on PHP 7.x (If no support by SAP is available and one definitely needs it.)

Ocramius commented 7 years ago

@heiglandreas yep, but we're not doing that (conversion), and next stable is gonna require PHP 7, so either an upgrade is coming soon, or we have to drop support ;-)

heiglandreas commented 7 years ago

Set SAP a date until they should react. No reaction => drop official support.

For those that want to roll their own dice: put relevant Doctrine files in separate repo so they can fetch and adapt them on a best effort base.

Ocramius commented 7 years ago

We're not dropping any files, just not testing any SAP support anymore (which is ~= no support)

efarrar commented 7 years ago

I am sorry for the frustration for the current lack of support for PHP7. The migration of the driver to PHP7 has involved significantly more work than previous upgrades due to internal changes to PHP's data structures. This upgrade is being actively worked on right now.

The link in the opening post to the PHP downloads is the old, archived link from the SAP Developer Network. We are not able to update that content any more, so new files are being posted in the SQL Anywhere Wiki on the SAP Community Network (https://wiki.scn.sap.com/wiki/display/SQLANY/The+SAP+SQL+Anywhere+PHP+Module)

I will update this thread once the new module is posted.

deeky666 commented 7 years ago

@efarrar thank you very much for this statement. I am glad to hear, that this has not been forgotten. This information is enough for us at the moment, we will simply stall testing on SQL Anywhere until the PHP7 driver version is ready. Maybe you should put a note on the wiki, that you are working on it because I have seen several comments in the old article asking about PHP7 support. That might help keeping users informed. Anyways, thanks again!

efarrar commented 7 years ago

The PHP 7.0 and PHP 7.1 libraries are now available for SQL Anywhere (https://wiki.scn.sap.com/wiki/display/SQLANY/The+SAP+SQL+Anywhere+PHP+Module)

cfreear commented 7 years ago

@efarrar you saint, been waiting a long time for this!

andipohl commented 7 years ago

@efarrar: great to see the sasql driver. But the source code seems to be the old one? Please upload the current one. thank you

blabtonic commented 7 years ago

@efarrar thanks so much for the updated version

andipohl commented 6 years ago

@efarrar May you please compile the SQL Anywhere-module for PHP 7.2? Are the sources somewhere available to compile it myself? Thank you

andipohl commented 6 years ago

Thanks to @efarrar: He uploaded the current sourcecode to SAP-Wiki

Ocramius commented 6 years ago

How are the sources being developed? Isn't there a repo for contributions to be suggested by the community?

On 19 Jan 2018 16:18, "Andreas Pohl" notifications@github.com wrote:

Thanks to @efarrar https://github.com/efarrar: He uploaded the current sourcecode to SAP-Wiki https://wiki.scn.sap.com/wiki/display/SQLANY/The+SAP+SQL+Anywhere+PHP+Module

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/doctrine/dbal/issues/2652#issuecomment-358994799, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakCr5vu0-bGFNObNNLpG3UhgKiZFkks5tMLIwgaJpZM4L8T0H .

efarrar commented 6 years ago

Currently the sources are being developed internally to the SQL Anywhere team (SAP). However, we now provide most of our other dynamic language drivers (Python, Ruby, etc) on our github pages (https://github.com/sqlanywhere). I think we should do the same for the SQL Anywhere PHP driver and will take this as an action item.

cfreear commented 6 years ago

Thanks for the update @efarrar, any chance of an official PHP 7.2 binary release?

Majkl578 commented 6 years ago

I think we should do the same for the SQL Anywhere PHP driver and will take this as an action item.

That would be great, less proprietary binaries is always better especially in Linux land. 👍 We can then try to resurrect #852 somehow to have a Travis stage for SASQL and see if there is any better way how to handle the developer key (maybe something changed during the 2 years period since that PR).

Majkl578 commented 6 years ago

SAP Wiki still doesn't provide binaries for PHP 7.2 at the end of April 2018 (5 months after PHP 7.2.0 release). Since DBAL 3.0 will be PHP 7.2+ only, this would mean there is no compatible combination of SQL Anywhere driver and DBAL.

morozov commented 6 years ago

There's extension source code available at the SAP Wiki.

I was able to build it against PHP 7.2 without any issues. Not that I'm advocating for keeping it supported, just the fact.

deeky666 commented 5 years ago

@efarrar the PHP driver sources are incompatible with PHP 7.3 it seems. Do you plan to add support for it and if so is there any ETA? Thank you.

cfreear commented 5 years ago

We are experiencing issues building the module for PHP 7.3 too but managed fine for 7.2

@efarrar are you the guy to talk to regarding this or has someone else taken over the PHP module project?

cfreear commented 5 years ago

Update:

I've had a reply from a staff member at the sqlany_interfaces@sap.com address found here informing me that they are working on a PHP 7.3 compatible version of the extension but they can't give an ETA on it's availability.

efarrar commented 5 years ago

The PHP driver has been updated, and new binaries have been created. You can find the source and binaries here: https://wiki.scn.sap.com/wiki/display/SQLANY/The+SAP+SQL+Anywhere+PHP+Module

Sorry for the delay in getting these uploaded.

efarrar commented 5 years ago

I have had to temporarily pull the Linux 7.2 and Linux 7.3 binaries as they had not yet been fully verified by QA. I hope to enable them again soon.

The Windows binaries and the updated source are still available.

Sorry for any inconvenience.

deeky666 commented 5 years ago

@efarrar thank you very much!

efarrar commented 5 years ago

All of the Linux drivers are now available: https://wiki.scn.sap.com/wiki/display/SQLANY/The+SAP+SQL+Anywhere+PHP+Module

rgfpy commented 4 years ago

Thanks @efarrar

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.