search

doctrine / dbal

Doctrine Database Abstraction Layer
https://www.doctrine-project.org/projects/dbal.html
MIT License
9.4k stars 1.33k forks source link

Ci no upload.x #6427

Closed grooverdan closed 4 weeks ago

grooverdan commented 4 weeks ago
Q A
Type improvement
Fixed issues

Summary

Allow CI to run in forked repos without failing on this explicit doctrine/dbal part of the github action workflows.

grooverdan commented 4 weeks ago

helps if I have a non-failing CI to demonstrate this: https://github.com/grooverdan/dbal/actions/runs/9413683501

greg0ire commented 4 weeks ago

The codecov upload sometimes works and is not a required check. When it works, it allows us to check that the patch is covered. I would leave things as is.

derrabus commented 4 weeks ago

But should the CodeCov upload run on forks as well?

greg0ire commented 4 weeks ago

Yes. And it very often does, check other PRs

derrabus commented 4 weeks ago

All right.