search

doctrine / dbal

Doctrine Database Abstraction Layer
https://www.doctrine-project.org/projects/dbal.html
MIT License
9.45k stars 1.33k forks source link

Add MariaDb1010Platform for fetchTableOptionsByTable #6434

Closed grooverdan closed 3 months ago

grooverdan commented 3 months ago
Q A
Type improvement
Fixed issues #6361

Summary

As requested: https://github.com/doctrine/dbal/pull/6425#discussion_r1631197858

The diverging MariaDB-10.10.1+ implementation of retrieving table options split the implementation so that its now in the AbstractMySQLPlatform and the MariaDB specific implementation in MariaDBPlatform.

On CI - I don't follow the 'useless $sql' error.

derrabus commented 3 months ago

Thank you. I've simplified the signature of fetchTableOptionsByTable() a little because the method didn't really use the information that you passed in.

derrabus commented 3 months ago

We get a lot of false positives from CodeCov these days unfortunately.

grooverdan commented 3 months ago

Thanks for the merge. Appoligies for missing the signature cleanup.