search

doctrine / doctrine-laminas-hydrator

Doctrine hydrators for Laminas applications
https://www.doctrine-project.org/projects/doctrine-laminas-hydrator.html
MIT License
33 stars 19 forks source link

Add PHP 8.2 support #62

Closed fezfez closed 1 year ago

fezfez commented 1 year ago

Signed-off-by: Stéphane Demonchaux demonchaux.stephane@gmail.com

driehle commented 1 year ago

Looks like phpspec/prophecy doesn't support 8.2 yet...

driehle commented 1 year ago

I dropped phpspec/prophecy with #65. Could you please rebase your PR on the latest 3.2.x branch?

fezfez commented 1 year ago

I dropped phpspec/prophecy with #65. Could you please rebase your PR on the latest 3.2.x branch?

done

fezfez commented 1 year ago

@driehle seem to be good :)

driehle commented 1 year ago

Looks good, but I a wondering if we should add a test case for readonly properties (PHP 8.1) and readonly classes (PHP 8.2). As uninitialized properties are ignored for extraction by reference...

https://github.com/doctrine/doctrine-laminas-hydrator/blob/3.2.x/src/DoctrineObject.php#L288

... readonly properties could be ignored for hydration by reference. What do you think?

fezfez commented 1 year ago

@driehle tests has beed added :)

fezfez commented 1 year ago

@driehle should be ok

driehle commented 1 year ago

Thanks, @fezfez, for you time and contribution! 3.2.0 has just been released!