Closed fezfez closed 1 year ago
Looks like phpspec/prophecy
doesn't support 8.2 yet...
I dropped phpspec/prophecy
with #65. Could you please rebase your PR on the latest 3.2.x
branch?
I dropped
phpspec/prophecy
with #65. Could you please rebase your PR on the latest3.2.x
branch?
done
@driehle seem to be good :)
Looks good, but I a wondering if we should add a test case for readonly properties (PHP 8.1) and readonly classes (PHP 8.2). As uninitialized properties are ignored for extraction by reference...
https://github.com/doctrine/doctrine-laminas-hydrator/blob/3.2.x/src/DoctrineObject.php#L288
... readonly properties could be ignored for hydration by reference. What do you think?
@driehle tests has beed added :)
@driehle should be ok
Thanks, @fezfez, for you time and contribution! 3.2.0 has just been released!
Signed-off-by: Stéphane Demonchaux demonchaux.stephane@gmail.com