search

doctrine / doctrine-laminas-hydrator

Doctrine hydrators for Laminas applications
https://www.doctrine-project.org/projects/doctrine-laminas-hydrator.html
MIT License
33 stars 19 forks source link

Updated dependencies #68

Closed driehle closed 1 year ago

driehle commented 1 year ago

This MR raises the minimum dependencies to their latest version

greg0ire commented 1 year ago

:thinking: what's the point of this?

driehle commented 1 year ago

🤔 what's the point of this?

Reducing potential incompatibilities, as CI only tests lowest and latest dependencies. Hence, the more far apart the lowest requirement in this project and the latest actual release are, the higher the risk of getting some issues.

The new lower bounds are all supported by PHP 8.0, so for me there is no reason in not raising the lower bounds.

greg0ire commented 1 year ago

Is this purely theoretical or based on an issue you observed where the CI was green but wouldn't have been if picking a version in the middle? I'm really not convinced about this reasoning, and even if I were, this is not the policy I've observed on other Doctrine repositories, except for development dependencies.

TomHAnderson commented 1 year ago

I agree with @greg0ire on this. Unless this is to address an issue then raising the minimum requirements just reduces the footprint of compatibility.

ostrolucky commented 1 year ago

I agree with others as well, let's close.