search

doctrine / doctrine-laminas-hydrator

Doctrine hydrators for Laminas applications
https://www.doctrine-project.org/projects/doctrine-laminas-hydrator.html
MIT License
33 stars 19 forks source link

Added support for date_immutable and time_immutable field types. #72

Closed TomHAnderson closed 1 year ago

TomHAnderson commented 1 year ago

Moved from #70 onto a different branch

@dkmuir

dkmuir commented 1 year ago

@TomHAnderson Ah, apologies. First time contributing. I've fixed the 3 lines flagged by the codesniffer check. What's the right way to push that through?

TomHAnderson commented 1 year ago

@dkmuir The CS isn't your problem. I've opened #73 to fix the underlying issue and will merge that first then rebase your commit.

TomHAnderson commented 1 year ago

@dkmuir To answer your question, a PR to my PR'd branch would be the way to do it.

driehle commented 1 year ago

Merged #73, would you mind rebasing?