search

doctrine / doctrine-laminas-hydrator

Doctrine hydrators for Laminas applications
https://www.doctrine-project.org/projects/doctrine-laminas-hydrator.html
MIT License
33 stars 19 forks source link

Use strcmp instead of spaceship operator to compare objects #75

Closed tomdrissen closed 1 year ago

tomdrissen commented 1 year ago

Use strcmp instead of spaceship operator to prevent some weird behaviour when comparing hashes with more than 16 characters, see issue https://github.com/doctrine/doctrine-laminas-hydrator/issues/71 .

tomdrissen commented 1 year ago

Something gone wrong while rebasing the changes in PR #74 so I've created a new PR for the 3.2.x branch @driehle.

driehle commented 1 year ago

Thanks, @tomdrissen!