search

doctrine / doctrine-sphinx-theme

Sphinx Theme for all Doctrine Documentations
4 stars 10 forks source link

please replace Twitter Bootstrap 2.x with Bootstrap 3.x #6

Open jonassmedegaard opened 8 years ago

jonassmedegaard commented 8 years ago

Twitter Bootstrap 2.x is dead upstream.

Please migrate to Bootstrap 3.x: https://getbootstrap.com/migration/

Ocramius commented 8 years ago

@jonassmedegaard there's no need for changing this unless we want to change the design of the site...

jonassmedegaard commented 8 years ago

so you see no problem in exposing to your users javascript code which noone maintains regarding security flaws or other problems?

Ocramius commented 8 years ago

@jonassmedegaard no, mainly because it's static pages with no possible user input except for disqus, which is in an iframe.

As far as I can see, we may even be able to strip down the remaining JS instead of upgrading.

jonassmedegaard commented 8 years ago

that'd be a sensible approach too - my worry is your distributing code that is unmaintained, not specifically to a solution of pushing to newer Bootstrap (sorry, I realize my initial post was misleading).

Ocramius commented 8 years ago

Yeah, the fact is that this is not really for redistributing: it's just some rudimentary template for the project site :-P On Oct 17, 2015 4:13 AM, "Jonas Smedegaard" notifications@github.com wrote:

that'd be a sensible approach too - my worry is your distributing code that is unmaintained, not specifically to a solution of pushing to newer Bootstrap (sorry, I realize my initial post was misleading).

— Reply to this email directly or view it on GitHub https://github.com/doctrine/doctrine-sphinx-theme/issues/6#issuecomment-148907900 .

jonassmedegaard commented 8 years ago

Quoting Marco Pivetta (2015-10-17 18:05:49)

Yeah, the fact is that this is not really for redistributing: it's just some rudimentary template for the project site :-P

It seems to me that it is used not only in your website design but also in the documentation of the ORM component: https://packages.debian.org/jessie/doctrine-orm-doc

Ocramius commented 8 years ago

Why is there even a package with the ORM docs? The docs are just supposed to be downloadable as PDF if needed :-\

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 18 October 2015 at 00:34, Jonas Smedegaard notifications@github.com wrote:

Quoting Marco Pivetta (2015-10-17 18:05:49)

Yeah, the fact is that this is not really for redistributing: it's just some rudimentary template for the project site :-P

It seems to me that it is used not only in your website design but also in the documentation of the ORM component: https://packages.debian.org/jessie/doctrine-orm-doc

  • Jonas

  • Jonas Smedegaard - idealist & Internet-arkitekt
  • Tlf.: +45 40843136 Website: http://dr.jones.dk/

[x] quote me freely [ ] ask before reusing [ ] keep private

— Reply to this email directly or view it on GitHub https://github.com/doctrine/doctrine-sphinx-theme/issues/6#issuecomment-148987006 .