doctrine / doctrine-website

Source code for the doctrine-project.org website and documentation.
https://www.doctrine-project.org
MIT License
31 stars 63 forks source link

Adapt to NavMenuNode #623

Closed greg0ire closed 1 month ago

greg0ire commented 1 month ago

In my previous PR, I copied code from https://github.com/phpDocumentor/guides/blob/main/packages/guides/resources/template/html/body/menu/table-of-content.html.twig That template has a different name than the one I copied the code into, so maybe it receives a different type of node? Anyway, I remembered how to actually build the docs and was able to create this version through trial and error rather than blindly copying code. But as you see, I do not fully understand what I am doing, hopefully somebody does.

greg0ire commented 1 month ago

@jaapio @linawolf please review

jaapio commented 1 month ago

You are right, that's another node, we might want to change this in guides. As it is confusing that the nodes do not behave the same way.