search

doctrine / inflector

Doctrine Inflector is a small library that can perform string manipulations with regard to uppercase/lowercase and singular/plural forms of words.
https://www.doctrine-project.org/projects/inflector.html
MIT License
11.26k stars 137 forks source link

Remove countable word #222

Closed driesvints closed 1 year ago

driesvints commented 1 year ago

The word "environment" is countable. Please see https://github.com/doctrine/inflector/pull/216#discussion_r1232174367

driesvints commented 1 year ago

The failing CI check is failing on 2.0.x as well.

greg0ire commented 1 year ago

I'd love to have your input on https://github.com/doctrine/inflector/issues/221 as well.

EilifAkerjordet commented 1 year ago

I would like to add that the same goes for the word "permission" - I see more words as well in #216 that are countable

greg0ire commented 1 year ago

When talking about "the environment" (as in :deciduous_tree: ), I think it's uncountable. But when talking about "an environment" it isn't, and in our jobs, it's more likely we are going to talk about the latter, so it seems fair to revert this. Should we revert other words as well, such as "permission"? Also, is there something we can do to prevent them from being added again? IIRC it's possible to add tests for this.

driesvints commented 1 year ago

Closing this as I don't think reverting just one word is the right approach.