search

doctrine / instantiator

https://www.doctrine-project.org/projects/instantiator.html
MIT License
10.94k stars 60 forks source link

Adapt ignore error message #104

Closed greg0ire closed 9 months ago

greg0ire commented 9 months ago

Looks like the "of object" part is no longer mentioned in recent PHPStan versions.

greg0ire commented 9 months ago

Now there is a broken Psalm build :man_facepalming: And I cannot reproduce it on the playground, which seems to be using the master branch for some reason. Trying to get help on this at https://symfony-devs.slack.com/archives/C8SFXTD2M/p1702073197631449

greg0ire commented 9 months ago

Yeah but that config is meant to go away in the (far?) future, and we probably would not think of removing that unneeded null initialization. Plus, if we can avoid touching working code for wrong reasons, it's probably best, right?

SenseException commented 9 months ago

if we can avoid touching working code for wrong reasons, it's probably best, right?

I agree with this and that's why I :white_check_mark: it.