doctrine / instantiator

https://www.doctrine-project.org/projects/instantiator.html
MIT License
10.95k stars 62 forks source link

Remove parameter annotation #45

Closed Valouleloup closed 6 years ago

Valouleloup commented 6 years ago

There is no sense to let this annotation if we accept classes that implement InstantiatorInterface with a parameter different than string

alcaeus commented 6 years ago

This is a major BC break for very similar reasons as in #44. I'm closing this as it makes no sense from my point of view, and to consolidate discussion around this in #44.

Even though we don't do scalar types yet, implementations of the interface rely on the docblock to provide implementation guidance and thus only expect string arguments.