Test against PHP 8 - Githubissues

doctrine / instantiator

https://www.doctrine-project.org/projects/instantiator.html

MIT License

10.95k stars 62 forks source link

Test against PHP 8 #68

Closed alcaeus closed 4 years ago

greg0ire commented 4 years ago

Something went very wrong, not sure what… TIL phpunit/phpunit depends on this package. Isn't there COMPOSER_ROOT_VERSION magic required for this to work?

greg0ire commented 4 years ago

Isn't there COMPOSER_ROOT_VERSION magic required for this to work?

Link to PR with said magic: github.com/doctrine/reflection/pull/37

alcaeus commented 4 years ago

COMPOSER_ROOT_VERSION did the trick and we've now got a stable PHP 8 build (although I'd still keepallowed_failures` for a while).

greg0ire commented 4 years ago

Thanks @alcaeus !