search

doctrine / instantiator

https://www.doctrine-project.org/projects/instantiator.html
MIT License
10.95k stars 62 forks source link

Add more generics #83

Closed franmomu closed 3 years ago

franmomu commented 3 years ago

I've just realised that the return type was missing.

PS: Nice work with the GA!

greg0ire commented 3 years ago

I've just realised that the return type was missing.

Does that mean this is a bugfix? Or should you target 1.5.x ?

franmomu commented 3 years ago

I've just realised that the return type was missing.

Does that mean this is a bugfix? Or should you target 1.5.x ?

To be honest, I don't know. When I did it I saw it as a bugfix considering that this part was missing, but it also can be seen as it works fine right now and is adding something more.

IMHO seeing adding generics as a whole, it's a bugfix.