search

doctrine / instantiator

https://www.doctrine-project.org/projects/instantiator.html
MIT License
10.95k stars 62 forks source link

Adapt to recent version of PHPUnit (10) #99

Closed DavidPrevot closed 1 year ago

DavidPrevot commented 1 year ago

Those changes allow the testsuite to also pass on PHPUnit 10.

Regards,

David

greg0ire commented 1 year ago

Hi David! It looks like you forgot to bump the version constraint here: https://github.com/doctrine/instantiator/blob/d6eef505a6c46e963e54bf73bb9de43cdea70821/composer.json#L28

In case you're wondering, this is why the checks are red.

Please make the change, amend your commit and force push.

DavidPrevot commented 1 year ago

Thanks for the hint (I thought I actually run the testsuite with PHPUnit 9 after the change, but obviously forgot).

greg0ire commented 1 year ago

You're welcome. I believe these lines need to be changed as well: https://github.com/doctrine/instantiator/blob/2.0.x/phpunit.xml.dist#L22-L26

They use old vocabulary (filter/ whitelist vs coverage / include)

greg0ire commented 1 year ago

Thanks @DavidPrevot !