Memoize object construction and method call result

[ghostwriter]

Description

The method getLiteral($token) currently creates a new ReflectionClass every time it's invoked, to get the constants defined on the static class.

This PR attempts to cache the first call and reuse it for subsequent calls.

Diff

--- a/lib/Doctrine/Common/Lexer/AbstractLexer.php
+++ b/lib/Doctrine/Common/Lexer/AbstractLexer.php
     public function getLiteral($token)
     {
+        static $constants = null;
         $className = static::class;
-        $reflClass = new ReflectionClass($className);
-        $constants = $reflClass->getConstants();
+        $constants = $constants ?? (new ReflectionClass($className))->getConstants();

once this package min support version is bumped to PHP 7.4

$constants = $constants ?? (new ReflectionClass($className))->getConstants();

can later be optimized/shortened to

$constants ??= (new ReflectionClass($className))->getConstants();

[derrabus]

Thank you. Please have a look at the CS failure.

[SenseException]

What does this PR introduce or is trying to fix? Can you please write a description?

[ghostwriter]

@SenseException done, ready for review.

[SenseException]

Thank you for clearing up the PR. It's now more understandable what you try to accomplish with the changes. Now it would help to understand "why". Did you run into memory issues or something different because of the repeated creation of the ReflectionClass instance?

[ghostwriter]

No!

• google "lexer site:packagist.org"
• found this package listed.
• follow the link to packagist.
• found the github link
• follow the link to github
• click on AbstractLexer.php
• review the code
• notice the bug ("repeated creation of the ReflectionClass instance" for a lookup table)
• create a PR to address this issue
• maintainer waste my time playing 21 questions to get a very simple and very obvious, memory & preference improvement merged
• lost interest in using this package

anything else you want to know?

[greg0ire]

Feel free to reopen a similar PR when you're ready to be respectful to maintainers. In the meantime, we'll make do without your contribution.