search

doctrine / migrations

Doctrine Database Migrations Library
https://www.doctrine-project.org/projects/migrations.html
MIT License
4.68k stars 385 forks source link

GH-1379: Improve Deprecation thrown check + logic #1381

Closed agustingomes closed 10 months ago

agustingomes commented 10 months ago

Unfortunately as part of the previous improvement to determine whether a deprecation is thrown, validating that the deprecation was not thrown ended up not being added explicitly.

In addition, adds the explicit expectation of not throwing the deprecation whenever the --all-or-nothing is not indicated, which was the root cause originating the issue.

Q A
Type bug
BC Break no
Fixed issues https://github.com/doctrine/migrations/issues/1379

Summary

When the deprecation was added, the check whether the deprecation is NOT triggered was missing. This PR should solve the underlying issue.

greg0ire commented 10 months ago

Thanks @agustingomes !