search

doctrine / migrations

Doctrine Database Migrations Library
https://www.doctrine-project.org/projects/migrations.html
MIT License
4.65k stars 387 forks source link

fix: Allow enum param types: ArrayParameterType and ParameterType #1408

Closed michalbundyra closed 4 months ago

michalbundyra commented 4 months ago
Q A
Type bug
BC Break no
Fixed issues #1407

Summary

Fixes #1407

A bit lame fix, but it looks like we did not really use other int types before anyway

With this change we can use DBAL v4 new enum types: ArrayParameterType and ParameterType.

Bumping version of DBAL to 3.6 as before that ArrayParameterType did not exist.

Just to note - the problem itself is ONLY with DBAL 4.0+ as on 3.6 these types were classes with constants, not enums.

derrabus commented 4 months ago

Thank you. Please add a test that covers your change.

michalbundyra commented 4 months ago

@derrabus thanks!

derrabus commented 4 months ago

Thank you!

derrabus commented 4 months ago

Let's do the bump in #1411.