Normalize `assert*()` calls in tests

[IonBazan]

Improvement

Currently assert*() calls are inconsistent between tests:

• self::assert*() (preferred)
• static::assert*() - good alternative for above, but tests should usually be final and overriding core methods is not expected
• $this->assert*() - this one is invalid as assertion methods are usually static

This should be enforced by static analysis/code style.

[hunomina]

I'll have a look at this 😉

[malarzm]

@hunomina I've merged your PR up to 2.5.x branch - would you like to change all remaining calls there? We had few features added to 2.5.x that were not present on 2.4.x.

[hunomina]

Oh! Sure, I can have a look 😉

[IonBazan]

@hunomina I think you missed a few hidden spots where we still call them non-statically: https://github.com/doctrine/mongodb-odm/blob/5fcca6cc7e5e93bd6d2f3ee4a2f08ca9e1689939/tests/Doctrine/ODM/MongoDB/Tests/Events/PreUpdateEventArgsTest.php#L74-L110

and

https://github.com/doctrine/mongodb-odm/blob/5fcca6cc7e5e93bd6d2f3ee4a2f08ca9e1689939/tests/Doctrine/ODM/MongoDB/Tests/Events/LifecycleListenersTest.php#L240-L270

There are quite camouflaged so it's really hard to spot them but we will be able to remove the $phpunit property completely there.

Can you submit a PR fixing those for 2.4.x?

BTW these listeners could perhaps be potentially replaced by anonymous classes.

[hunomina]

I searched for occurrences using \$this->.*assert this time.

I could only find two of them. PR coming right up 😄

[hunomina]

There you go. I'll create another PR to fix 2.5.x 😉

[IonBazan]

I think we can close it here