Fix some phpstan warnings

doctrine / mongodb

PHP MongoDB Abstraction Layer

https://www.doctrine-project.org/projects/mongodb.html

MIT License

442 stars 190 forks source link

Fix some phpstan warnings #320

Closed vkhramtsov closed 6 years ago

alcaeus commented 6 years ago

Thanks for your contribution, @vkhramtsov! Unfortunately, this library is in maintenance-only mode, so I won't be merging this. The code has been merged into doctrine/mongodb-odm, where we also made similar changes and added phpstan to our CI build: https://github.com/doctrine/mongodb-odm/pull/1714. We're currently running on a low level, so if you want to increase the level and fix some errors over in the ODM repository, we'd really appreciate it!

vkhramtsov commented 6 years ago

@alcaeus Would you be so kind to write about maintenance-mode only in readme? Just to prevent creation PR's like this.

alcaeus commented 6 years ago

Of course. Just did so in 94844dcaa39d2bad3189bd924f20d6a67c8ca424.

vkhramtsov commented 6 years ago

Thank you