[WIP] Improvements / Refactoring

doctrine / orientdb-odm

A set of PHP libraries in order to use OrientDB from PHP

http://odino.org/blog/categories/orientdb/

MIT License

155 stars 54 forks source link

[WIP] Improvements / Refactoring #159

Open prolic opened 11 years ago

prolic commented 11 years ago

This is my first PR to get in touch with doctrine orientdb odm:

add EventManager [WIP: make use of it]
refactor getRepository method to check for repository class in class meta data [WIP: missing tests]

odino commented 11 years ago

totally pro this PR! :+1:

What about adding / fixing the tests?

prolic commented 11 years ago

I am still working on this one. See the title WIP (Work in Progress).

odino commented 11 years ago

sweet!

odino commented 11 years ago

@nrk this PR looks awesome to me. What do you say, merge it?

@prolic thanks for the effort! :)

prolic commented 11 years ago

Sorry for being so late. My initial goal to complete this is way beyond. Actually, it should be ready to merge, however I would like to make further additions, but that could also be handled in another PR.

odino commented 11 years ago

@prolic yup, you can go with another PR. Im waiting @nrk's feedback to merge it

nrk commented 11 years ago

@odino sorry I won't be able to review @prolic's PR right now until the end of the month, but as far as I remember the last time I checked it seemed OK to me (admittedly I couldn't find the time to test or have a deeper look into the code).