doctrine / orm

Doctrine Object Relational Mapper (ORM)
https://www.doctrine-project.org/projects/orm.html
MIT License
9.86k stars 2.5k forks source link

Fix fromMappingArray definition #11408

Closed VincentLanglet closed 2 months ago

VincentLanglet commented 2 months ago

Hi,

Kinda similar to https://github.com/doctrine/orm/pull/11226 @greg0ire @derrabus

I got a psalm error because FieldMapping::fromMappingArray does not accept nullable key. This was because the array param was missing lot of keys.

I tried to fix the phpdoc of every fromMappingArray keys by looking at all the property of the class and allow them as array keys in the $mappingArray parameter.

Thanks.

greg0ire commented 2 months ago

Thanks @VincentLanglet !