Revert "SchemaValidator: Changing mapping of BIGINT to string|int"

doctrine / orm

Doctrine Object Relational Mapper (ORM)

https://www.doctrine-project.org/projects/orm.html

MIT License

9.92k stars 2.51k forks source link

Revert "SchemaValidator: Changing mapping of BIGINT to string|int" #11415

Closed derrabus closed 5 months ago

derrabus commented 5 months ago

I'm reverting #11399 in favor of an upmerge of #11414 which gives us a more consistent developer experience across DBAL and ORM releases.

cc @ThomasLandauer

ThomasLandauer commented 5 months ago

So I did it in 3.1 and you did the ~same in 2.19 and now propagate/cascade/inherit it to 3.1? And this is called an upmerge? But what are "downstream projects"?

So the bottom line stays the same: This is the way to go for the future?:

#[Column(type: Types::BIGINT)]
private string|int $bigint;

derrabus commented 5 months ago

So I did it in 3.1 and you did the ~same in 2.19 and now propagate/cascade/inherit it to 3.1? And this is called an upmerge?

Yes, see #11416.

But what are "downstream projects"?

Your application.

So the bottom line stays the same: This is the way to go for the future?:
#[Column(type: Types::BIGINT)]
private string|int $bigint;

That would be valid, although I personally prefer this version for my projects:

#[Column(type: Types::BIGINT)]
private int $bigint;

ThomasLandauer commented 5 months ago

So "downstream projects" means just "projects that are using the ORM". And "upstream projects" doesn't exist?

#[Column(type: Types::BIGINT)]
private int $bigint;

=> Cool - even better! :-)

derrabus commented 5 months ago

So "downstream projects" means just "projects that are using the ORM". And "upstream projects" doesn't exist?

Upstream projects from the ORM's perspective would be DBAL, Persistence, Symfony VarExporter, the PHP runtime, …

=> Cool - even better! :-)

✌🏻