search

doctrine / orm

Doctrine Object Relational Mapper (ORM)
https://www.doctrine-project.org/projects/orm.html
MIT License
9.86k stars 2.5k forks source link

Allow classname in 'value' attribute of xml discriminator-mapping field #11450

Closed MatteoFeltrin closed 1 month ago

MatteoFeltrin commented 1 month ago

fixes https://github.com/doctrine/orm/issues/11449

In relation to https://github.com/doctrine/orm/pull/10630 This PR allows a more loosen validation of the value attribute of discriminator-mapping field, using orm:type in the XSD schema as it was done in the linked pull request. The test I written loads the entity enabling the validation against XSD schema, thus expects no exception to be thrown.

greg0ire commented 1 month ago

According to https://github.com/doctrine/orm/issues/11208, you're probably not targeting the right branch.

MatteoFeltrin commented 1 month ago

Closing to start from the correct branch

greg0ire commented 1 month ago

@MatteoFeltrin it is possible to retarget a PR with the edit button.

MatteoFeltrin commented 1 month ago

@greg0ire sorry for my ignorance, it was the first time contributing to an upstream repository, I forked with only with 3.1.x branch and didn't know how to add the correct one, so preferred to do it from scratch 😅

greg0ire commented 1 month ago

No worries.